This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
remove example blacklist #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
force-pushed
the
remove-example-blacklist
branch
from
e141329 to
5ff2da8
Compare
| Usage: "Path to file containing blacklisted addresses, json-encoded list of strings. Default assumes CWD is repo's root", | ||
| Value: "ofac_blacklist.json", | ||
| Usage: "Path to file containing blacklisted addresses, json-encoded list of strings", | ||
| Value: "", |
There was a problem hiding this comment.
nit: while I agree that it makes sense to remove the blacklist, I think it would be good to provide an example schema of the blacklist.json with a simple but concrete instantiation conforming to the schema so users know how they should structure the blacklist should they choose to use one
1 task
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
This one was not maintained and it's the responsibility of the entity running the builder to decide on and maintain a blacklist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
remove example blacklist
this one was not maintained and it's the responsibility of the entity running the builder to decide on and maintain a blacklist
Closes #11
CONTRIBUTING.md