Add support for additional block building algorithm #76

Wazzymandias · 2023-06-14T22:03:15Z

📝 Summary

This PR adds support for a new block building algorithm type, called greedy-buckets
The new algorithm attempts to insert transactions by both effective gas price and profit. This is in contrast to the greedy algorithm which simply uses effective gas price

Testing

Tested locally and on production mainnet
Observed a healthy number of higher bids with the new algorithm, screenshot below compares how often the new algorithm in blue outbid the existing one in orange:

Below is a chart that compares top bid of each algorithm per block building attempt

📚 References

The Knapsack Problem with Conflict Graphs

I have seen and agree to CONTRIBUTING.md

…er than static size from max element of heap

…ting algorithm

core/types/transaction.go

miner/algo_common.go

miner/algo_greedy.go

…hiftAndPushByAccountForTx

dvush

I think this is what we want!

left some comment

miner/algo_common.go

miner/algo_greedy_buckets.go

core/types/transaction.go

…tries

miner/algo_common.go

miner/algo_greedy_buckets.go

…ck-algo

miner/algo_common.go

… add profit enforcement for transactions

miner/algo_common.go

…ce implications of rolling back state on low profit

…ck-algo

miner/worker.go

miner/algo_greedy_buckets.go

…eedy buckets algorithm to only reinsert when low profit error occurs. Update TxWithMinerFee to set price and set profit after low profit error to reinsert back into heap

* Add initial implementation for builder bucketized merging algorithm * Simplify logic and update buckets to initialize from top of heap rather than static size from max element of heap * Add logic to commit transactions when heap is empty * Fix erroneous integer division * Move profit function to TxWithMinerFee pointer receiver, refactor sorting algorithm * Add logic for enforcing profit on bundles and sbundles * Split greedy buckets builder from greedy builder * Add greedy bucket worker * Update tests to support separate greedy buckets builder, add retry logic * Make new multi worker explicit in supported algorithm types, update ShiftAndPushByAccountForTx * Reduce retry count to 1, update signature formatting * Add else statement with panic clause for unsupported order type in algo greedy buckets * Update greedy buckets algorithm to use gas used for transaction on retries * Remove tx profit validation for the scope of this PR due to performance implications of rolling back state on low profit * Update method signatures to algoConf * Move closures to outside function, add low profit error and update greedy buckets algorithm to only reinsert when low profit error occurs. Update TxWithMinerFee to set price and set profit after low profit error to reinsert back into heap

Wazzymandias added 7 commits June 12, 2023 19:57

Add initial implementation for builder bucketized merging algorithm

571a2a3

Simplify logic and update buckets to initialize from top of heap rath…

75de38c

…er than static size from max element of heap

Add logic to commit transactions when heap is empty

96af7eb

Fix erroneous integer division

44cce7a

Refactor function signatures

631a995

Revert algo type since lots of tight coupling to it

d3a6c14

Update unit tests, pass in builder algorithm type to greedy builder

9f3eb5a

Wazzymandias requested review from dvush, Ruteri and avalonche June 14, 2023 22:03

Wazzymandias added 5 commits June 14, 2023 17:11

Fix linter error

a54912e

Add comment

5aec42b

Move profit function to TxWithMinerFee pointer receiver, refactor sor…

a489dc7

…ting algorithm

Add logic for enforcing profit on bundles and sbundles

32a38d8

Fix unit tests

d184abc

Ruteri reviewed Jun 15, 2023

View reviewed changes

miner/algo_greedy.go Outdated Show resolved Hide resolved

miner/algo_greedy.go Outdated Show resolved Hide resolved

miner/algo_greedy.go Outdated Show resolved Hide resolved

miner/algo_greedy.go Outdated Show resolved Hide resolved

Wazzymandias added 5 commits June 15, 2023 10:31

Split greedy buckets builder from greedy builder

9c67c26

Add greedy bucket worker

b226b8c

Update tests to support separate greedy buckets builder, add retry logic

e422c3b

Rename function for retry and push

76206d7

Fix README, update comments

b71bc56

Wazzymandias requested a review from Ruteri June 16, 2023 21:45

Make new multi worker explicit in supported algorithm types, update S…

13be2e9

…hiftAndPushByAccountForTx

dvush reviewed Jun 20, 2023

View reviewed changes

Wazzymandias added 2 commits June 21, 2023 16:35

Address PR feedback

359517d

Fix unit test

1c5300a

Wazzymandias force-pushed the build-300/improve-block-algo branch from 9f740a6 to 1c5300a Compare June 21, 2023 22:36

Wazzymandias requested a review from dvush June 21, 2023 22:48

Wazzymandias changed the title ~~[WIP] Add support for additional block building algorithm~~ Add support for additional block building algorithm Jun 22, 2023

Wazzymandias requested a review from Ruteri June 23, 2023 15:16

Wazzymandias added 2 commits June 23, 2023 16:03

Update unit test

e20aab1

Update greedy buckets algorithm to use gas used for transaction on re…

9a463fb

…tries

dvush reviewed Jun 26, 2023

View reviewed changes

miner/algo_common.go Outdated Show resolved Hide resolved

miner/algo_common.go Outdated Show resolved Hide resolved

dvush reviewed Jun 26, 2023

View reviewed changes

miner/algo_greedy_buckets.go Show resolved Hide resolved

Wazzymandias added 2 commits June 26, 2023 09:15

Address PR feedback

d2a2a86

Merge remote-tracking branch 'origin/main' into build-300/improve-blo…

5cea23a

…ck-algo

Wazzymandias requested a review from dvush June 26, 2023 14:35

Remove print statements used for debugging

59ee5cd

Ruteri reviewed Jun 27, 2023

View reviewed changes

miner/algo_common.go Outdated Show resolved Hide resolved

miner/algo_common.go Outdated Show resolved Hide resolved

miner/algo_common.go Show resolved Hide resolved

Wazzymandias force-pushed the build-300/improve-block-algo branch 2 times, most recently from 960e40b to 5136f70 Compare June 28, 2023 02:18

Add support for test builder algorithm for parallelized algo testing,…

c9cad3d

… add profit enforcement for transactions

Wazzymandias force-pushed the build-300/improve-block-algo branch from 5136f70 to c9cad3d Compare June 28, 2023 05:42

Wazzymandias requested a review from Ruteri June 28, 2023 15:44

Ruteri reviewed Jun 28, 2023

View reviewed changes

miner/algo_common.go Outdated Show resolved Hide resolved

miner/algo_common.go Outdated Show resolved Hide resolved

Wazzymandias added 2 commits June 28, 2023 11:52

Remove tx profit validation for the scope of this PR due to performan…

19feb4a

…ce implications of rolling back state on low profit

Update unit test

647309f

Wazzymandias requested a review from Ruteri June 28, 2023 17:26

Wazzymandias added 3 commits June 28, 2023 12:27

Update method signatures to algoConf

0df6b29

Update references of validation conf to algo conf

4b9e2c3

Merge remote-tracking branch 'origin/main' into build-300/improve-blo…

8eccf03

…ck-algo

Ruteri approved these changes Jun 28, 2023

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

miner/algo_greedy_buckets.go Outdated Show resolved Hide resolved

Remove test only algorithm from PR

76aec25

dvush approved these changes Jun 29, 2023

View reviewed changes

miner/algo_greedy_buckets.go Show resolved Hide resolved

Move closures to outside function, add low profit error and update gr…

adaaf14

…eedy buckets algorithm to only reinsert when low profit error occurs. Update TxWithMinerFee to set price and set profit after low profit error to reinsert back into heap

Wazzymandias force-pushed the build-300/improve-block-algo branch from f43740c to adaaf14 Compare June 29, 2023 21:27

Wazzymandias merged commit 44debde into main Jun 30, 2023

Wazzymandias deleted the build-300/improve-block-algo branch June 30, 2023 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for additional block building algorithm #76

Add support for additional block building algorithm #76

Wazzymandias commented Jun 14, 2023 •

edited

Loading

dvush left a comment

Add support for additional block building algorithm #76

Add support for additional block building algorithm #76

Conversation

Wazzymandias commented Jun 14, 2023 • edited Loading

📝 Summary

Testing

📚 References

dvush left a comment

Choose a reason for hiding this comment

Wazzymandias commented Jun 14, 2023 •

edited

Loading