[WIP] Dcap tdx attestation #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruteri
force-pushed
the
baremetal-tdx-attestation-rebase
branch
from
64e1792
to
a02b670
Compare
Ruteri
commented
Sep 18, 2024
| ) | ||
|
|
||
| replace github.com/edgelesssys/go-tdx-qpl => github.com/ruteri/go-tdx-qpl v0.0.0-20240705142333-1da84ccf7c1b |
There was a problem hiding this comment.
This is hopefully not needed any more, but needs testing!
metachris
reviewed
Sep 18, 2024
cmd/proxy-client/main.go
Outdated
| }, | ||
| &cli.StringFlag{ | ||
| Name: "attestation-type", | ||
| Value: "azure", |
There was a problem hiding this comment.
Suggested change
| Value: "azure", | |
| Value: "azure-tdx", |
There was a problem hiding this comment.
should be consts, ideally
metachris
reviewed
Sep 18, 2024
cmd/proxy-server/main.go
Outdated
| }, | ||
| &cli.StringFlag{ | ||
| Name: "attestation-type", | ||
| Value: "azure", |
There was a problem hiding this comment.
Suggested change
| Value: "azure", | |
| Value: "azure-tdx", |
There was a problem hiding this comment.
forgot about this one i guess?
metachris
reviewed
Sep 18, 2024
Makefile
Outdated
Comment on lines
32
to
46
| .PHONY: lint | ||
| lint: | ||
| gofmt -d -s . | ||
| gofumpt -d -extra . | ||
| go vet ./... | ||
| staticcheck ./... | ||
| golangci-lint run | ||
| nilaway ./... | ||
|
|
||
| .PHONY: fmt | ||
| fmt: | ||
| gofmt -s -w . | ||
| gci write . | ||
| gofumpt -w -extra . | ||
| go mod tidy |
There was a problem hiding this comment.
lint + fmt should ignore internal
Suggested change
| .PHONY: lint | |
| lint: | |
| gofmt -d -s . | |
| gofumpt -d -extra . | |
| go vet ./... | |
| staticcheck ./... | |
| golangci-lint run | |
| nilaway ./... | |
| .PHONY: fmt | |
| fmt: | |
| gofmt -s -w . | |
| gci write . | |
| gofumpt -w -extra . | |
| go mod tidy | |
| .PHONY: lint | |
| lint: | |
| gofmt -d -s . | |
| gofumpt -d -extra cmd common proxy tdx | |
| go vet ./... | |
| staticcheck ./... | |
| golangci-lint run | |
| nilaway ./... | |
| .PHONY: fmt | |
| fmt: | |
| gofmt -s -w cmd common proxy tdx | |
| gci write cmd common proxy tdx | |
| gofumpt -w -extra cmd common proxy tdx | |
| go mod tidy |
metachris
reviewed
Sep 18, 2024
go.mod
Outdated
| go 1.22.4 | ||
|
|
||
| toolchain go1.23.0 | ||
| go 1.23 |
There was a problem hiding this comment.
why increase the minimum go version?
Ruteri
force-pushed
the
baremetal-tdx-attestation-rebase
branch
from
b1319c5
to
f703c80
Compare
metachris
reviewed
Sep 19, 2024
| } | ||
| } | ||
|
|
||
| func server_side_tls_termination(cCtx *cli.Context) error { |
There was a problem hiding this comment.
could simplify?
Suggested change
| func server_side_tls_termination(cCtx *cli.Context) error { | |
| func run_server(cCtx *cli.Context) error { |
metachris
reviewed
Sep 19, 2024
| } | ||
| } | ||
|
|
||
| func client_side_tls_termination(cCtx *cli.Context) error { |
There was a problem hiding this comment.
could simplify?
Suggested change
| func client_side_tls_termination(cCtx *cli.Context) error { | |
| func run_client(cCtx *cli.Context) error { |
|
closing in favour of #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked WIP again - needs a rebase and adjustments to dcap validation logic.