-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSE Payload Attributes subscription #318
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 18.34% 17.94% -0.41%
==========================================
Files 20 20
Lines 3559 3639 +80
==========================================
Hits 653 653
- Misses 2826 2905 +79
- Partials 80 81 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
services/api/service.go
Outdated
} | ||
log := api.log.WithField("proposalSlot", proposalSlot) | ||
|
||
log.Info("updating payload attributes") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function will be called multiple times for each payload attributes -- namely once per CL client. therefore this function should somehow guard against it.
question: do we need to support multiple parents? or do we just always use the latest received one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to compare the parent hash as well but I think we can use the hash from the "best" BN from in the multi-BN instance to keep consistent state?
1fcfc61
to
32a2e6e
Compare
9da38d0
to
cd56de9
Compare
Co-authored-by: Chris Hager <chris@linuxuser.at>
Co-authored-by: Chris Hager <chris@linuxuser.at>
cd56de9
to
31b7476
Compare
Deployed to Sepolia and Zhejiang testnets! |
📝 Summary
Adds SSE payload attributes subscription on the relay.
⛱ Motivation and Context
As part of ethereum/beacon-APIs#305 SSE endpoint providing payload attributes allows the relay to retrieve
prev_randao
andwithdrawals
with a custom BN fork to retrieve this information.📚 References
✅ I have run these commands
make lint
make test-race
go mod tidy
CONTRIBUTING.md