[fix] redis.GetBidTrace should return err=redis.Nil on missing item
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
changed the title
metachris
changed the title
redis.GetBidTrace should return err=redis.Nil on missing item
metachris
changed the title
redis.GetBidTrace should return err=redis.Nil on missing itemredis.GetBidTrace should return err=redis.Nil on missing item
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 30.85% 30.86% +0.01%
==========================================
Files 24 24
Lines 4739 4736 -3
==========================================
Hits 1462 1462
+ Misses 3079 3076 -3
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
If
redis.GetBidTracedoesn't find the item, it should returnredis.Nilas error, instead of no error. This is only used in https://github.com/flashbots/mev-boost-relay/blob/getBidTrace-fix2/services/api/service.go#L1361 which would crash when saving the delivered payload when this happens (the bidTrace not being found in Redis).Extends #467
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md