optimistic v2 slowpath #530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## mikeneuder-2023-09-08-01 #530 +/- ##
============================================================
+ Coverage 35.64% 36.07% +0.42%
============================================================
Files 24 24
Lines 5387 5467 +80
============================================================
+ Hits 1920 1972 +52
- Misses 3243 3266 +23
- Partials 224 229 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
metachris
reviewed
Oct 2, 2023
| eligibleAt time.Time | ||
| pf common.Profile | ||
| entry *blockBuilderCacheEntry | ||
| gasLimit uint64 | ||
| } | ||
|
|
||
| func (api *RelayAPI) optimisticV2SlowPath(r io.Reader, v2Opts v2SlowPathOpts) { |
There was a problem hiding this comment.
a bit of docs would be nice, to outline what'll happen in this function
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Completion of the v2 code. This is diffed off #524 to make the review clearer.
This follows up on the series: #479, #491, #494, #498, #513, #514, #518, #524 which aim at reducing the diff and productionizing #466.
⛱ Motivation and Context
This PR implements the slow path of the v2 code, which parses the full transactions and withdrawals, saves the payload, and runs the simulation.
📚 References
https://notes.ethereum.org/@mikeneuder/optimistic-v2
https://github.com/michaelneuder/optimistic-relay-documentation/blob/main/towards-epbs.md#optimistic-relay-v2-header-only-parsing
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md