New http client for every beacon request #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Apr 11, 2024
beaconclient/util.go
Outdated
| @@ -55,11 +55,9 @@ func fetchBeacon(method, url string, payload []byte, dst any, timeout *time.Dura | |||
| } | |||
| req.Header.Set("accept", "application/json") | |||
|
|
|||
| client := http.DefaultClient | |||
| client := &http.Client{} | |||
| if timeout != nil && timeout.Seconds() > 0 { | |||
There was a problem hiding this comment.
probably should change .Seconds() to .Milliseconds() while at this
metachris
approved these changes
Apr 11, 2024
metachris
approved these changes
Apr 11, 2024
avalonche
added a commit
that referenced
this pull request
Apr 11, 2024
* Add flag to publish block with ssz * profiling * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * Update beaconclient/prod_beacon_instance.go Co-authored-by: Chris Hager <chris@linuxuser.at> * fix naming * add slot to log * New http client for every beacon request (#603) * New http client for every beacon request * use milliseconds for timeout --------- Co-authored-by: Chris Hager <chris@linuxuser.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use new HTTP client for every beacon node request to improve latency instead of reusing the same connection.
⛱ Motivation and Context
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md