Use dedicated http client for publishing #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +182,7 @@ func (c *ProdBeaconInstance) SyncStatus() (*SyncStatusPayloadData, error) { | |||
| uri := c.beaconURI + "/eth/v1/node/syncing" | |||
| timeout := 5 * time.Second | |||
| resp := new(SyncStatusPayload) | |||
| _, err := fetchBeacon(http.MethodGet, uri, nil, resp, &timeout, http.Header{}, false) | |||
| _, err := fetchBeacon(http.MethodGet, uri, nil, resp, &http.Client{Timeout: timeout}, http.Header{}, false) | |||
There was a problem hiding this comment.
question:
why do we create a new client (and as a result a new TCP connection per each request) only for /eth/v1/node/syncing path?
There was a problem hiding this comment.
(just to qualify, I think we shouldn't create a new client for this path either. so that there are only 2 clients in use, the default for everything, and one dedicated for publishing only).
There was a problem hiding this comment.
It's just to configure the timeout I think, will update to have 1 client in use for everything with a 5 second timeout (is that enough for the validator request?)
avalonche
force-pushed
the
publish-http-client
branch
from
cf30329
to
d69fab0
Compare
metachris
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
⛱ Motivation and Context
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md