BLS key script improvement: allow hex string input #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
Apr 26, 2024
| "github.com/flashbots/go-boost-utils/bls" | ||
| ) | ||
|
|
||
| func main() { | ||
| sk := GenSecretKey() | ||
| // sk := SecretKeyFromHexString("0x") |
There was a problem hiding this comment.
what's this used for? shouldn't this script use command line args to parse hex string and generate a new one if not provided?
There was a problem hiding this comment.
it's used for checking a hex secret key, and converting that into secret key + getting public key for it. it's just for testing / dev, using CLI args seems overkill for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
scripts/create-bls-keypair: allow hex string as inputjust used as a helper, not part of the relay logic
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md