Validate blockhash that the relayer responds with #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
metachris
reviewed
Sep 9, 2022
avalonche
force-pushed
the
validate-response-blockhash
branch
2 times, most recently
from
04949a4 to
a554ed3
Compare
metachris
force-pushed
the
validate-response-blockhash
branch
from
8b7fa1a to
575926b
Compare
metachris
requested review from
jtraglia,
lightclient,
ralexstokes and
terencechain
jtraglia
requested changes
Oct 17, 2022
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
metachris
approved these changes
Oct 19, 2022
screwyprof
pushed a commit
to screwyprof/mev-boost
that referenced
this pull request
Feb 3, 2023
* Validate blockhash that the relayer responds with * update test * update getPayload response hash check * Update server/service_test.go Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: Chris Hager <chris@linuxuser.at> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Validates the block hash the relay responds with the hash calculated from the relay block.
β± Motivation and Context
Resolves #280
π References
β I have run these commands
make lintmake test-racego mod tidy