Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render usage as text instead of bash #388

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Render usage as text instead of bash #388

merged 1 commit into from
Oct 28, 2022

Conversation

jtraglia
Copy link
Collaborator

@jtraglia jtraglia commented Oct 28, 2022

📝 Summary

Minor change. In the README, the usage (mev-boost -help) should be rendered as text instead of bash.

⛱ Motivation and Context

Some of the words (keywords) had syntax highlighting. I found it a bit distracting:

image


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #388 (999bf5e) into main (eacfd5b) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   66.66%   66.77%   +0.11%     
==========================================
  Files           7        7              
  Lines         888      888              
==========================================
+ Hits          592      593       +1     
+ Misses        262      259       -3     
- Partials       34       36       +2     
Flag Coverage Δ
unittests 66.77% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/main.go 13.51% <0.00%> (ø)
server/mock_relay.go 86.92% <ø> (ø)
server/service.go 79.52% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jtraglia jtraglia merged commit 46c074f into flashbots:main Oct 28, 2022
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants