Ensure that fork version is 4 bytes #395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
If a custom genesis fork version that's fewer than 4 bytes (e.g.,
-genesis-fork-version 0xabcd
) is specified, the missing bytes will be filled with "random" bytes (e.g.,0xabcd6364
). This PR will return an error if the fork version isn't exactly 4 bytes. Previously, it only returned an error if it was greater than 4 bytes.⛱ Motivation and Context
Fixes #277.
✅ I have run these commands
make lint
make test-race
go mod tidy