Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI latest Docker image tagging #413

Merged
merged 1 commit into from
Nov 19, 2022
Merged

fix CI latest Docker image tagging #413

merged 1 commit into from
Nov 19, 2022

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Nov 17, 2022

📝 Summary

Fix CI overwriting the latest Docker image with both portable and non-portable images (as seen here in the latest release CI action: https://github.com/flashbots/mev-boost/actions/runs/3428613593/jobs/5713128560)

Currently, the latest image on Docker hub is the portable image.

This PR updates the Docker release CI step to do that explicitly.

Also removes pushing images for :1 and :1.4 when releasing v1.4.0 (these image tags seem unnecessary and I'd opt for removing them from Docker hub, otherwise we should also add them for portable).

See also #412


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #413 (b83b128) into main (ead84e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   65.93%   65.93%           
=======================================
  Files           7        7           
  Lines         907      907           
=======================================
  Hits          598      598           
  Misses        274      274           
  Partials       35       35           
Flag Coverage Δ
unittests 65.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metachris metachris merged commit d5f7061 into main Nov 19, 2022
@metachris metachris deleted the ci-docker-3 branch November 19, 2022 08:55
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants