Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme fixes #420

Merged
merged 1 commit into from
Nov 23, 2022
Merged

readme fixes #420

merged 1 commit into from
Nov 23, 2022

Conversation

metachris
Copy link
Collaborator

📝 Summary

incorporate feedback from #417


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

jtraglia
jtraglia previously approved these changes Nov 22, 2022
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #420 (8680c06) into main (9953a37) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   66.04%   65.93%   -0.12%     
==========================================
  Files           7        7              
  Lines         907      907              
==========================================
- Hits          599      598       -1     
- Misses        271      274       +3     
+ Partials       37       35       -2     
Flag Coverage Δ
unittests 65.93% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/service.go 77.75% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metachris metachris merged commit 75736d9 into main Nov 23, 2022
@metachris metachris deleted the readme-fix branch November 23, 2022 09:01
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants