Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme + release cleanup #468

Merged
merged 3 commits into from
Mar 15, 2023
Merged

readme + release cleanup #468

merged 3 commits into from
Mar 15, 2023

Conversation

metachris
Copy link
Collaborator

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

RELEASE.md Outdated Show resolved Hide resolved
@@ -54,11 +54,13 @@ git tag -s v2.3.1-rc1 # without a tag, the Docker image would include the wrong
# now push to Github (CI will build the Docker image: https://github.com/flashbots/mev-boost/actions)
git push origin --tags

# you can also manually create and push the Docker image
# all done here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all done here" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, all is done here :)

README.md Outdated Show resolved Hide resolved
metachris and others added 2 commits March 15, 2023 12:54
Co-authored-by: shana <avalonche@protonmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #468 (ba7a7d5) into main (10abc1a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   68.64%   68.64%           
=======================================
  Files           8        8           
  Lines        1263     1263           
=======================================
  Hits          867      867           
  Misses        346      346           
  Partials       50       50           
Flag Coverage Δ
unittests 68.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metachris metachris merged commit dbc02c6 into main Mar 15, 2023
@metachris metachris deleted the readme-cleanup5 branch March 15, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants