-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme + release cleanup #468
Conversation
@@ -54,11 +54,13 @@ git tag -s v2.3.1-rc1 # without a tag, the Docker image would include the wrong | |||
# now push to Github (CI will build the Docker image: https://github.com/flashbots/mev-boost/actions) | |||
git push origin --tags | |||
|
|||
# you can also manually create and push the Docker image | |||
# all done here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"all done here" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, all is done here :)
Co-authored-by: shana <avalonche@protonmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 68.64% 68.64%
=======================================
Files 8 8
Lines 1263 1263
=======================================
Hits 867 867
Misses 346 346
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ I have run these commands
make lint
make test-race
go mod tidy