Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add per-slot-uid to getHeader and getPayload #498

Merged
merged 5 commits into from
Jun 7, 2023
Merged

add per-slot-uid to getHeader and getPayload #498

merged 5 commits into from
Jun 7, 2023

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

Add a unique ID per slot to getHeader and getPayload.

Closes #492


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #498 (af573ad) into develop (54eeaa2) will decrease coverage by 0.14%.
The diff coverage is 65.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
- Coverage    70.24%   70.10%   -0.14%     
===========================================
  Files            6        8       +2     
  Lines          541     1291     +750     
===========================================
+ Hits           380      905     +525     
- Misses         132      337     +205     
- Partials        29       49      +20     
Flag Coverage Ξ”
unittests 70.10% <65.80%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
cli/main.go 0.00% <0.00%> (ΓΈ)
cli/types.go 0.00% <0.00%> (ΓΈ)
server/mock_types.go 100.00% <ΓΈ> (ΓΈ)
server/types.go 70.00% <70.00%> (ΓΈ)
server/service.go 77.34% <75.31%> (+5.32%) ⬆️
server/utils.go 82.58% <85.15%> (+15.01%) ⬆️
server/mock_relay.go 88.44% <90.81%> (+5.58%) ⬆️
server/relay_entry.go 90.00% <100.00%> (+8.75%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good! I'd consider more precise keying that is more flexible and "harder to get wrong", esp during times where this feature is most needed

server/service.go Show resolved Hide resolved
server/service.go Show resolved Hide resolved
server/service.go Outdated Show resolved Hide resolved
server/service.go Show resolved Hide resolved
@metachris metachris deleted the branch develop May 16, 2023 12:31
@metachris metachris closed this May 16, 2023
@metachris metachris reopened this May 17, 2023
@metachris metachris changed the base branch from main to develop May 17, 2023 14:00
@metachris metachris requested a review from ralexstokes May 17, 2023 20:40
metachris and others added 3 commits June 3, 2023 10:43
ralexstokes
ralexstokes previously approved these changes Jun 5, 2023
@metachris
Copy link
Collaborator Author

Merging now, since it was re-reviewed by @ralexstokes already, and I added a commit with only a minor header key change

@metachris metachris merged commit da02856 into develop Jun 7, 2023
@metachris metachris deleted the slot-uid branch June 7, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unique request ID to getHeader and getPayload calls.
4 participants