-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add per-slot-uid to getHeader and getPayload #498
Conversation
Codecov Report
β Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #498 +/- ##
===========================================
- Coverage 70.24% 70.10% -0.14%
===========================================
Files 6 8 +2
Lines 541 1291 +750
===========================================
+ Hits 380 905 +525
- Misses 132 337 +205
- Partials 29 49 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good! I'd consider more precise keying that is more flexible and "harder to get wrong", esp during times where this feature is most needed
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Merging now, since it was re-reviewed by @ralexstokes already, and I added a commit with only a minor header key change |
π Summary
Add a unique ID per slot to getHeader and getPayload.
Closes #492
β I have run these commands
make lint
make test-race
go mod tidy