Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-eth2-client's IsInfinity() to check relay pubkey #630

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

jtraglia
Copy link
Collaborator

📝 Summary

Just fixing a few things I noticed while reviewing.

  • Use go-eth2-client's IsInfinity function to check the relay pubkey.
  • Provide valid pubkey to TestParseRelaysURLs & TestHexToPublicKey tests.
  • Add additional test cases to TestParseRelaysURLs.
  • Uncomment "invalid hexadecimal input" tests, might as well.
  • Update go-boost-utils to v1.8.1 and run go mod tidy.

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.56%. Comparing base (d263722) to head (f5924f3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #630      +/-   ##
===========================================
+ Coverage    52.37%   52.56%   +0.18%     
===========================================
  Files           14       14              
  Lines         1600     1600              
===========================================
+ Hits           838      841       +3     
+ Misses         706      702       -4     
- Partials        56       57       +1     
Flag Coverage Δ
unittests 52.56% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

avalonche
avalonche previously approved these changes Feb 29, 2024
@metachris metachris merged commit 74a8ecb into flashbots:develop Apr 4, 2024
2 checks passed
@jtraglia jtraglia deleted the use-is-infinity-func branch April 4, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants