Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: refactor handleGetHeader #643

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MariusVanDerWijden
Copy link
Collaborator

📝 Summary

This pulls out the verification logic into verifyBid which makes it easier to unit test in the future. It also changes the logic for parallelizing the requests to the builder from using a shared mutex to computing the requests in parallel and assembling the best response after the fact on the main thread

⛱ Motivation and Context

This PR makes verifyBid easier to unit test as it does not depend on setting up multiple relays etc.
This PR also removes some very un-standard logic of using a shared mutex to compute the best bid.

I am not 100% sure about the performance implications of this PR, but I think it should be faster in my opinion, since we do not need to wait for the locking of the mutex

This pulls out the verification logic into verifyBid which makes it
easier to unit test in the future. It also changes the logic for
parallelizing the requests to the builder from using a shared mutex
to computing the requests in parallel and assembling the best response
after the fact on the main thread
@avalonche avalonche requested a review from jtraglia April 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant