Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urfave flags fix #673

Merged
merged 1 commit into from
Aug 6, 2024
Merged

urfave flags fix #673

merged 1 commit into from
Aug 6, 2024

Conversation

metachris
Copy link
Collaborator

📝 Summary

Follow-up to #660 , fixing one missing env var

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

jtraglia
jtraglia approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch 👍

@metachris metachris merged commit 1fed7bb into develop Aug 6, 2024
4 checks passed
@metachris metachris deleted the flags-fix branch August 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metachris @jtraglia