Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复redis_sentinel标签异常 #1109

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

ttbug
Copy link
Contributor

@ttbug ttbug commented Dec 16, 2024

这里的tag修改的都是client.tags这个map,每一次修改都会更新同名标签,并且导致tag累积,后面的指标被添加了很多无关的标签

@@ -183,7 +183,11 @@ func convertSentinelInfoOutput(
scanner := bufio.NewScanner(rdr)
rawFields := make(map[string]string)

tags := globalTags
// tags := globalTags
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行注释的代码辛苦清理了吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

清理了

@kongfei605
Copy link
Collaborator

Thank you @ttbug

@kongfei605 kongfei605 merged commit 7bb3d94 into flashcatcloud:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants