Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Window Support? #390

Closed
noamgat opened this issue Jul 23, 2024 · 3 comments
Closed

Sliding Window Support? #390

noamgat opened this issue Jul 23, 2024 · 3 comments

Comments

@noamgat
Copy link

noamgat commented Jul 23, 2024

Hi!
I'm using FlashInfer under vLLM as it is the only implementation there that supports logit capping, which is required for the gemma2 model. However, vLLM disables sliding window attention because FlashInfer doesn't support it, limiting the context length of gemma2 from 8k to 4k.
Is there a plan to add support for this?

@yzh119
Copy link
Collaborator

yzh119 commented Jul 23, 2024

Yes, I'm working on that, will be available in v0.1.2

@noamgat
Copy link
Author

noamgat commented Jul 23, 2024

Awesome! Happy to hear!

yzh119 added a commit that referenced this issue Jul 29, 2024
As requested in #390 , this PR implements sliding window attention.

This PR also result in slight performance degration because we didn't
specialize kernels that use/not use sliding window. I believe we can
address them by landing the JIT compilation feature. I'll merge this
feature first and improve performance in later PRs.
@yzh119
Copy link
Collaborator

yzh119 commented Jul 29, 2024

Done in #406 , available in v0.1.2 release.

@yzh119 yzh119 closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants