Fix missing symbols in trtllm_utils.so #1168
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tiran, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical runtime linking error within the trtllm_utils.so library. It achieves this by updating the build configurations in flashinfer/aot.py and flashinfer/utils.py to explicitly include common helper source files, thereby providing the previously missing symbols required for successful execution.
Highlights
- Dependency Resolution: The pull request addresses an
OSError: undefined symbolby ensuring thetrtllm_utils.solibrary correctly links against necessary common helper files. - Build Configuration Update: Source files for common utilities like
envUtils.cpp,logger.cpp,stringUtils.cpp, andtllmException.cpphave been added to both the Ahead-of-Time (AOT) and Just-In-Time (JIT) compilation processes fortrtllm_utils.so.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an undefined symbol error by linking additional source files when building trtllm_utils.so. The fix is applied to both the AOT compilation script and the JIT utility function. I've added one comment suggesting a refactor to address code duplication and improve maintainability.
The `trtllm_utils` library also needs symbols from common files, e.g. the `llmException`. Extend the dependencies to link `trtllm_utils.so` with common helpers. ```python >>> flashinfer.utils.get_trtllm_utils_module() Traceback (most recent call last): ... OSError: ...flashinfer/data/aot/trtllm_utils/trtllm_utils.so: undefined symbol: _ZTIN12tensorrt_llm6common13TllmExceptionE ``` Fixes: flashinfer-ai#1167 Signed-off-by: Christian Heimes <christian@python.org>
|
I have addressed the |
|
@yzh119 You are welcome :) Thanks for improving and landing my fix! |
## 📌 Description The `trtllm_utils` library also needs symbols from common files, e.g. the `llmException`. Extend the dependencies to link `trtllm_utils.so` with common helpers. ```python >>> flashinfer.utils.get_trtllm_utils_module() Traceback (most recent call last): ... OSError: ...flashinfer/data/aot/trtllm_utils/trtllm_utils.so: undefined symbol: _ZTIN12tensorrt_llm6common13TllmExceptionE ``` ## 🔍 Related Issues Fixes: flashinfer-ai#1167 ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> --------- Signed-off-by: Christian Heimes <christian@python.org> Co-authored-by: Zihao Ye <expye@outlook.com>
2 participants
📌 Description
The
trtllm_utilslibrary also needs symbols from common files, e.g. thellmException. Extend the dependencies to linktrtllm_utils.sowith common helpers.🔍 Related Issues
Fixes: #1167
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes