misc: enhance allocator error info and add shape check for prefill begin forward functions #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
yzh119
added a commit
that referenced
this pull request
Jul 31, 2024
## [0.1.3](v0.1.2...v0.1.3) (2024-07-31) ### Bugfix * bugfix: Fix cudagraph mode of BatchPrefillWithRaggedKVCacheWrapper ([#412](#412)) ([9907bc](9907bc1)) * fix cu118 cub usage for sampling kernels ([#410](#410)) ([58d359](58d3593)) ### Misc * enhance allocator error info and add shape check for prefill begin forward functions ([#413](#413)) ([5e36c5](5e36c52))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the codebase:
begin_forwardfunctions to make sureqoandkvindptr array size matches.These efforts are designed for avoiding issues such as #362 , which needs to be fixed on vllm side, but we should have more friendly debugging information for locating the potential bugs.