Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bmm_fp8_no_scale #485

Closed
wants to merge 1 commit into from
Closed

feat: add bmm_fp8_no_scale #485

wants to merge 1 commit into from

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 31, 2024

No description provided.

@zhyncs zhyncs requested review from Ying1123 and yzh119 August 31, 2024 17:29
@zhyncs zhyncs added the wip work in progress label Aug 31, 2024
@zhyncs
Copy link
Member Author

zhyncs commented Sep 1, 2024

It seems that bmm_fp8 with scale is enough, so I'll close this for now. Thanks!
ref sgl-project/sglang#1285 And after that, I'll update the unit test.

@zhyncs zhyncs closed this Sep 1, 2024
@zhyncs zhyncs deleted the no-scale branch September 1, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant