[Performance] Accelerate cooperative kernel in single/batch decode. #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR don't show stable performance, use #72 instead. |
diptorupd
pushed a commit
to ROCm/flashinfer
that referenced
this pull request
Sep 29, 2025
This PR adds the necessary headers for mma ops. It also adds a unit test for a `16x16` `MFMA` op using wavefront intrinsics. To test the PR ``` cd flashinfer/libflashinfer/tests/hip/ ``` ``` mkdir build && cd build ``` ``` cmake -DCMAKE_PREFIX_PATH=/root/libtorch -DCMAKE_CXX_COMPILER:PATH=/opt/rocm/bin/amdclang++ -DFLASHINFER_INCLUDE_DIRS=/root/flashinfer/libflashinfer/include .. ``` ``` make test_mfma_fp32_16x16x16fp16 ``` ``` ./test_mfma_fp32_16x16x16fp16 ``` The result should look like ``` [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from MfmaTest [ RUN ] MfmaTest.CorrectResults [ OK ] MfmaTest.CorrectResults (2348 ms) [----------] 1 test from MfmaTest (2348 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (2348 ms total) [ PASSED ] 1 test. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single/batch decode (the implementation w/o Tensor Cores) can still be improved with better scheduling after
grid.sync().