Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FLASHINFER_BUILD_VERSION in nightly build #660

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix FLASHINFER_BUILD_VERSION in nightly build #660

merged 1 commit into from
Dec 13, 2024

Conversation

ur4t
Copy link
Contributor

@ur4t ur4t commented Dec 13, 2024

No description provided.

@ur4t
Copy link
Contributor Author

ur4t commented Dec 13, 2024

@zhyncs Sorry for breaking nightly builds for since #643.

This PR should be considered as urgent hotfix and we should move to setuptools-scm instead of parsing revisions manually.

yzh119
yzh119 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@yzh119 yzh119 merged commit 56f8eca into flashinfer-ai:main Dec 13, 2024
@ur4t ur4t deleted the hotfix-build-version branch December 14, 2024 09:20
@zhyncs zhyncs mentioned this pull request Dec 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ur4t @yzh119