Add dev container for easier development #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I use SGLang dev for local development and testing with FlashInfer. https://github.com/sgl-project/sglang/blob/main/docker/Dockerfile.dev |
|
@yzh119 can we merge this? |
yzh119
reviewed
Jan 27, 2025
.devcontainer/devcontainer.json
Outdated
| } | ||
| }, | ||
| "remoteUser": "root" | ||
| } |
There was a problem hiding this comment.
please insert a newline at the end of file :)
|
Added a non root user in the dockerfile to fix the same issue as sgl-project/sglang#2989 |
yzh119
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to develop inside a prebuilt container. This can save a lot of efforts of setting up cuda toolkit etc.
ref: https://code.visualstudio.com/docs/devcontainers/containers