Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: various AOT issues #752

Merged
merged 1 commit into from
Jan 25, 2025
Merged

bugfix: various AOT issues #752

merged 1 commit into from
Jan 25, 2025

Conversation

abcdabcd987
Copy link
Member

  1. Add missing instantiation for batch prefill and single prefill.
  2. Skip FP8 in sm90 prefill dispatch.
  3. Fix the incorrect prefill pybind declaration.
  4. Fix mismatched uri for batch prefill
  5. Add a DISPATCH_head_dim_sm90 since SM90 only supports 64, 128, 256.
  6. Remove csrc/aot_default_additional_params.h and add to gitignore.

@abcdabcd987 abcdabcd987 requested a review from yzh119 January 25, 2025 03:46
yzh119
yzh119 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yzh119 yzh119 merged commit 6e6f38d into flashinfer-ai:main Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abcdabcd987 @yzh119