Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Security best practice to remove autologin #1914

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Security best practice to remove autologin #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02b9b4
remove autologin
andy-v-h May 24, 2022
a01f6ed
Create 2022-5-24-remove-autologin-for-packet-oem.md
andy-v-h May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/security/2022-5-24-remove-autologin-for-packet-oem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Remove `flatcar.autologin` as a default kernel argument for best practices on packet-oem overlay.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Remove `flatcar.autologin` as a default kernel argument for best practices on packet-oem overlay.
- Equinix Metal: Remove `flatcar.autologin` as a default kernel argument for making it harder to get system access through the serial console. Users that want to use the OOB console have to either set up a user password (and make sure that SSH password login is disabled) or set the kernel argument when provisioning through the Ignition v3 kargs setting (requires Flatcar major version >=3185) ([coreos-overlay#1914](https://github.com/flatcar-linux/coreos-overlay/pull/1914))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think the changelog/changes/ folder fits this better as no security issue was addressed but an OS change is done that requires users to adapt to the change

1 change: 0 additions & 1 deletion coreos-base/oem-packet/files/grub.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Flatcar GRUB settings

set oem_id="packet"
jepio marked this conversation as resolved.
Show resolved Hide resolved
set linux_append="flatcar.autologin"

if [ "$grub_cpu" = i386 ]; then
set gfxpayload="1024x768x8,1024x768"
Expand Down