This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unshare expects a single command with arguments but the "sh -c" was forgotten here.
krnowak
approved these changes
Sep 26, 2023
tormath1
reviewed
Sep 26, 2023
docs/provisioning/sysext/_index.md
Outdated
You can list the contents of a systemd-sysext image like this (assuming an image without dm-verity): | ||
|
||
``` | ||
sudo unshare -m sh -c "mount docker-compose-2.18.1.raw /tmp && cd /tmp && find usr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
sudo unshare -m sh -c "mount docker-compose-2.18.1.raw /tmp && cd /tmp && find usr" | |
sudo unshare -m sh -c "mount docker-compose-2.18.1.raw /tmp && cd /tmp && find usr opt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can only be both, or? Have added a comment for opt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'd suggest even:
Suggested change
sudo unshare -m sh -c "mount docker-compose-2.18.1.raw /tmp && cd /tmp && find usr" | |
sudo unshare -m sh -c "mount docker-compose-2.18.1.raw /tmp && cd /tmp && find ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first idea but since only usr
is considered I thought to make it explicit.
Have now added a comment for that and switched back to .
.
When unsure what files an image ships or why the image is not compatible it can help to list the image contents or show the debug output from the matching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysext: Add debugging commands
When unsure what files an image ships or why the image is not compatible
it can help to list the image contents or show the debug output from the
matching.
Correct unshare mount command for listing /etc
Unshare expects a single command with arguments but the "sh -c" was
forgotten here.
How to use
Testing done
Ran the command for the docker compose image.