initrd-setup-root-after-ignition: Use update key for initrd sysext DL #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 20, 2023
This pulls in flatcar/bootengine#71 to switch the extension download to use the update server and the update key for verification of the payloads.
pothos
force-pushed
the
kai/fallback-update-key
branch
2 times, most recently
from
8febf6a
to
c598795
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 20, 2023
This pulls in flatcar/bootengine#71 to switch the extension download to use the update server and the update key for verification of the payloads.
krnowak
reviewed
Sep 21, 2023
Comment on lines
+20
to
+22
| if [ "$(usrbin md5sum /sysroot/usr/share/update_engine/update-payload-key.pub.pem | cut -d " " -f 1)" = "7192addf4a7f890c0057d21653eff2ea" ]; then | ||
| URL="https://bincache.flatcar-linux.net/images/${FLATCAR_BOARD/-usr}/${VERSION}/flatcar_test_update-${name}" |
There was a problem hiding this comment.
Could you add a comment about this magic number (a hash of some testing key?)
There was a problem hiding this comment.
Yes, that's the dev key, done.
| rm -rf "${GNUPGHOME}" | ||
| rm -f "/sysroot/${name}" | ||
| usrcurl -o "/sysroot/${name}" "${URL}" || { rm -f "/sysroot/${name}" ; return 1 ; } | ||
| PROTOPATH=/usr/share/update_engine/ usrbin unshare -m sh -c "mount --rbind /dev /sysroot/dev/ && mount -t proc /proc /sysroot/proc/ && chroot /sysroot /usr/share/update_engine/decode_payload /usr/share/update_engine/update-payload-key.pub.pem \"/${name}\" \"/${final_name}\"" || { rm -f "/sysroot/${final_name}" ; echo "Failing boot" >&2 ; exit 1; } |
There was a problem hiding this comment.
Should maybe the PROTOPATH env var be specified somewhere inside the sh -c parameter? It probably works where it is now, but it's quite far away from the actual user of the variable.
The OEM and "official" Flatcar systemd-sysext images have a download mechanism in the initrd. For OEM extensions this is only a fallback in case the user deleted the files because now we have all things in place for the update to ensure that OEM payloads are there. The enabling of "official" Flatcar extensions on provisioning still would primarily go through this mechanism and therefore, it should not use the image signing key but the update key to have a single way of verifying the extensions. Switch the extension download to use the update server and the update key for verification of the payloads.
For the OEM extension fallback download the networking was enabled, for the "official" Flatcar extension download not. Enable networkd and resolved like done for the OEM extension download.
pothos
force-pushed
the
kai/fallback-update-key
branch
from
c598795
to
6650fe4
Compare
krnowak
approved these changes
Sep 21, 2023
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 21, 2023
This pulls in flatcar/bootengine#71 to switch the extension download to use the update server and the update key for verification of the payloads.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 21, 2023
This pulls in flatcar/bootengine#71 to switch the extension download to use the update server and the update key for verification of the payloads.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 2, 2023
This pulls in flatcar/bootengine#71 to switch the extension download to use the update server and the update key for verification of the payloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OEM and "official" Flatcar systemd-sysext images have a download mechanism in the initrd. For OEM extensions this is only a fallback in case the user deleted the files because now we have all things in place for the update to ensure that OEM payloads are there. The enabling of "official" Flatcar extensions on provisioning still would primarily go through this mechanism and therefore, it should not use the image signing key but the update key to have a single way of verifying the extensions.
Switch the extension download to use the update server and the update key for verification of the payloads.
How to use
Testing done
Kola test
cl.sysext.fallbackdownloadstill passes