initrd-setup-root-after-ignition: Clean up incomplete move target #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When possible we prefer to have the active OEM systemd-sysext live on the OEM partition to support cleaning up the rootfs without bricking the instance. However, "mv" doesn't clean up the incomplete target file which would fill the OEM disk, and that could cause future problems. Clean up the incomplete move target that filled the OEM disk when trying to store the active OEM sysext image there.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2023
This pulls in flatcar/update_engine#29 and flatcar/bootengine#76 to fix the problem of not being able to update from ≤ 3619.0.0 on Azure.
2 tasks
krnowak
approved these changes
Oct 16, 2023
|
Let's get this in for the releases this week. |
krnowak
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 16, 2023
This pulls in flatcar/update_engine#29 and flatcar/bootengine#76 to fix the problem of not being able to update from ≤ 3619.0.0 on Azure.
krnowak
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 16, 2023
This pulls in flatcar/update_engine#29 and flatcar/bootengine#76 to fix the problem of not being able to update from ≤ 3619.0.0 on Azure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When possible we prefer to have the active OEM systemd-sysext live on the OEM partition to support cleaning up the rootfs without bricking the instance. However, "mv" doesn't clean up the incomplete target file which would fill the OEM disk, and that could cause future problems. Clean up the incomplete move target that filled the OEM disk when trying to store the active OEM sysext image there.
How to use
Backport to Alpha/Beta because it is a potential bug fix.
Testing done
in flatcar/scripts#1272