Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition: Create /run/ignition.env on every boot #86

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

pothos
Copy link
Member

@pothos pothos commented Feb 12, 2024

The rework of the generator moved the creation of the /run/ignition.env file to the setup script but that was only running on the first boot while the /run/ignition.env file should exist on every boot. Move the creation to its own "ignition-setup-pre" service that always runs.

How to use

Backport to flatcar-3874

Testing done

Checked that oem-cloudinit.service won't fail on second boot and that /run/ignition.env exists.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

The rework of the generator moved the creation of the /run/ignition.env
file to the setup script but that was only running on the first boot
while the /run/ignition.env file should exist on every boot.
Move the creation to its own "ignition-setup-pre" service that always
runs.
pothos added a commit to flatcar/scripts that referenced this pull request Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the
previous rework that only created /run/ignition.env on the first boot
while we rely on it to run cloud-init on every boot when no Ignition
config was provided.
pothos added a commit to flatcar/scripts that referenced this pull request Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the
previous rework that only created /run/ignition.env on the first boot
while we rely on it to run cloud-init on every boot when no Ignition
config was provided.
@pothos pothos requested a review from a team February 12, 2024 17:03
@pothos pothos merged commit 0b32311 into flatcar-master Feb 12, 2024
@pothos pothos deleted the kai/create-run-ignition.env branch February 12, 2024 17:57
pothos added a commit to flatcar/scripts that referenced this pull request Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the
previous rework that only created /run/ignition.env on the first boot
while we rely on it to run cloud-init on every boot when no Ignition
config was provided.
pothos added a commit to flatcar/scripts that referenced this pull request Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the
previous rework that only created /run/ignition.env on the first boot
while we rely on it to run cloud-init on every boot when no Ignition
config was provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant