Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/updateengine: ReceiveStatuses() may get nil signal on shutdown and panic #101

Open
invidian opened this issue Nov 24, 2021 · 2 comments
Labels
bug Something isn't working component/agent Agent-related issue

Comments

@invidian
Copy link
Member

Originally reported here: coreos/bugs#1987

However, coreos/locksmith@8b0a62e doesn't seem like a correct fix for it, as you can avoid getting nil signal completely, if you wait for receiver loop to shut down, e.g. by waiting for the final nil value from given ch on the process spawning ReceiveStatuses() goroutine.

Also related: godbus/dbus#271

@invidian invidian added the bug Something isn't working label Nov 24, 2021
@invidian
Copy link
Member Author

Actually, this does not affect agent, as it always drains the receive channel, but it's important to notice when consuming pkg/updateengine directly, so we should have unit tests for this.

@invidian
Copy link
Member Author

This also happens when you close the client before stopping the receiver routine, so clearly a bug.

@invidian invidian added the component/agent Agent-related issue label Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/agent Agent-related issue
Projects
None yet
Development

No branches or pull requests

1 participant