Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D-Bus improvements #108

Merged
merged 4 commits into from
Jan 6, 2022
Merged

D-Bus improvements #108

merged 4 commits into from
Jan 6, 2022

Conversation

invidian
Copy link
Member

@invidian invidian commented Dec 1, 2021

Signed-off-by: Mateusz Gozdek mgozdek@microsoft.com

@invidian invidian force-pushed the invidian/dbus-improvements branch 5 times, most recently from 795d3ad to c175983 Compare December 2, 2021 09:16
@invidian
Copy link
Member Author

invidian commented Dec 2, 2021

So, pkg/dbus and pkg/login1 packages are ready. Tests for pkg/updatenegine must be rewritten to use new package, then agent needs to adopt it.

@invidian invidian force-pushed the invidian/dbus-improvements branch 3 times, most recently from 0b61c70 to 8ab6f21 Compare December 2, 2021 22:00
@invidian invidian marked this pull request as ready for review December 2, 2021 22:05
@invidian
Copy link
Member Author

invidian commented Dec 2, 2021

This is ready to merge I think. Remaining optimizations like sharing the connection between login1 and updateengine, addressing #101 #102 can be done later, as all the ground work is now done.

@invidian invidian mentioned this pull request Dec 3, 2021
Open
10 tasks
@invidian
pkg/dbus: initial commit
812389f 
This commit adds initial commit for dbus package containing helpers for
creating a D-Bus client.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
pkg/updateengine/client_test.go: fix import sorting
3ac1d29 
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
pkg/updateengine: rename dbus import to godbus
b3b7acf 
So we can introduce internal dbus package.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
pkg/updateengine: rewrite tests and code to use new dbus package
373e9b1 
This is a safe step before moving creation of D-Bus connection to agent
and eventually agent CLI code, which however requires development of
tests on the agent code itself.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian invidian force-pushed the invidian/dbus-improvements branch from 8ab6f21 to 373e9b1 Compare January 6, 2022 13:30
@invidian invidian merged commit 64b7f88 into master Jan 6, 2022
@invidian invidian deleted the invidian/dbus-improvements branch January 6, 2022 13:38
@invidian invidian added this to the v0.9.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@invidian