kola: Skip cl.sysext.fallbackdownload for release builds #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have no way to switch the update pub key in the initrd to be a dev key (or vice versa). Thus the test cl.sysext.fallbackdownload failed because based on the key either the update server or bincache is tried. Skip cl.sysext.fallbackdownload for release builds at least temporarily. Later we might use a kernel cmdline setting or similar to switch the key to a dev key.
tormath1
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have no way to switch the update pub key in the initrd to be a dev key (or vice versa). Thus the test cl.sysext.fallbackdownload failed because based on the key either the update server or bincache is tried.
Skip cl.sysext.fallbackdownload for release builds at least temporarily. Later we might use a kernel cmdline setting or similar to switch the key to a dev key.
How to use
Testing done
Locally, once for the nightly (dev build), once for the new Alpha (release build)