use existing resource group #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can be used to deploy resources in an existing resource group Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
can be used to deploy instances in. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
pothos
reviewed
Jan 24, 2024
platform/machine/azure/cluster.go
Outdated
| @@ -89,7 +89,7 @@ func (ac *cluster) NewMachine(userdata *conf.UserData) (platform.Machine, error) | |||
| // delete the Resource Group if the cluster runs in the Flight's image Resource Group | |||
| func (ac *cluster) Destroy() { | |||
| ac.BaseCluster.Destroy() | |||
| if ac.ResourceGroup != ac.flight.ImageResourceGroup { | |||
| if ac.ResourceGroup != ac.flight.ImageResourceGroup || ac.flight.Api.Opts.ResourceGroup == "" { | |||
There was a problem hiding this comment.
Can you add a comment here? It looks like the additional condition is either not needed or if you want to be sure, then use && ac.flight.Api.Opts.ResourceGroup != "".
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
this can be helpful when we want to exclude from deletion a resource in a given resource group. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
it preserves the resource group but deletes what we created in it. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/azure
branch
from
8783fbe
to
4059ff0
Compare
tormath1
changed the title
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/azure
branch
from
4059ff0
to
59adc62
Compare
|
Closing in favor of: #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it as a regular Azure test but you can provide the resource group and keep it after the test.