Fix tang test (part 2) #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
force-pushed
the
fix-tang-test-part2
branch
from
e2e16a1
to
94bccea
Compare
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
fix-tang-test-part2
branch
from
94bccea
to
4256012
Compare
krnowak
reviewed
Mar 20, 2024
platform/local/cluster.go
Outdated
| @@ -93,6 +93,20 @@ func (lc *LocalCluster) GetOmahaHostPort() (string, error) { | |||
| return net.JoinHostPort(lc.hostIP(), port), nil | |||
| } | |||
|
|
|||
| func (lc *LocalCluster) NewTangListener() (*net.Listener, error) { | |||
There was a problem hiding this comment.
This does not seem to be specific at all to Tang, so maybe name it NewListenerInsideClusterNS?
There was a problem hiding this comment.
makes sense - pushed the change
The current version of the test creates a host socket which is affected by host iptables settings. This is why both tang tests are currently failing on our hosted infra. Rework the test to create a listener in the network namespace of the kola flight, which avoids host networking issues. We still have to dynamically find a port to avoid test case port collision, because kola runs all (qemu) tests inside the same network namespace. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
fix-tang-test-part2
branch
from
3a1c7dc
to
41c9bf9
Compare
|
I ran a test with this PRs container image here: http://jenkins.infra.kinvolk.io:8080/job/container/job/test/20754/console |
krnowak
approved these changes
Mar 20, 2024
Are they still failing? |
|
Yes, it still fails because we're missing this fix (WIP): flatcar/bootengine#90. That will come later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tang test by moving the tang listener into the qemu network namespace.
Also an attempt to speed up container build so the second commit will be pushed after the first build completes.