Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed count display for packages #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anistark
Copy link

@anistark anistark commented Oct 2, 2024

Fixes issue #599

@ErvinRacz
Copy link
Contributor

ErvinRacz commented Feb 20, 2025

Hello @anistark
Thank you for your pull request and for taking the time to work on this issue! I'm sorry that it took a long time to get back to you with a response. Your fix is much appreciated! :)

After the first look at #599 I thought that the issue is only with the paginator itself which cannot display the total count as your solution also suggests, however I would challenge this understanding:

There seems to be two problems with the state management of the packages. The List component doesn't react to the creation of a new package properly even if pagination is not required.

Here you can see that I have posted a new package. However, the 8th package gets displayed only after a browser refresh, however the 8th package should already be fetched according to the network tab:

Screenshot 2025-02-20 112054

Would you like to check out why this might happen? I don't know if that' the case, but it might have an impact on the implementation of your fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants