-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-boot/grub: update to 2.06 #1082
Conversation
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
It's from Gentoo commit 97daf89c0e60fa163c04990d17635cdebd83e579.
Another fresh CI builds with the accomodated patches: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1013/ |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5961101552 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - lets review the getenv
thing when we update shim and get secure boot working.
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-boot/grub/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com> Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
c923c25
to
c1aae63
Compare
sys-boot/grub: update to 2.06
Fixes flatcar/Flatcar#1099
Testing done
CI Passed (except for few arches) http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1009/cldsv/
CI Running
http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1013/cldsv/
Reviews from the previous PR flatcar-archive/coreos-overlay#2098
@krnowak
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - This seems to be required, and this is required to construct IUSE, and MULTIBUILD variant used in the ebuild
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Fixed this
@pothos
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - I've fixed the commits, and have added a README.md file adding a bit of context as well as the list of commits picked.
sys-boot/grub: sync with gentoo upstream; updates to 2.06 flatcar-archive/coreos-overlay#2098 (comment) - Tested and looks good, the downgrade worked successfully but did not affect the grub, which stayed at 2.06
Changelog entries added in the respective
changelog/
directory (user-facing change, bug fix, security fix, update)Inspected CI output for image differences:
/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.