Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sysext image for VMware OEM #1146

Merged
merged 30 commits into from
Sep 25, 2023
Merged

Sysext image for VMware OEM #1146

merged 30 commits into from
Sep 25, 2023

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Sep 15, 2023

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages/4451/cldsv/

  • net-libs/rpcsvc-proto: [PROD] [DEV]

  • dev-libs/xmlsec: [VMWARE]

    • new package, at 1.3.1
    • a dependency of app-emulation/open-vm-tools
  • dev-libs/libmspack: [VMWARE]

    • still at 0.10.1_alpha-r1
    • moved from overlay to portage-stable and added to automation
      • Flatcar modifications were dropped, as they were about putting stuff in to /oem
    • EAPI 8
    • dropped static-libs USE flag
  • sys-fs/fuse-common: [VMWARE]

    • new package, at 3.10.4
    • a dependency of sys-fs/fuse
  • sys-fs/fuse: [VMWARE]

    • new package, at 3.16.1
    • a dependency of app-emulation/vmware
    • pulling in an unstable version, as it fixes an issue with cross-compilation
  • dev-libs/libdnet: [VMWARE]

  • app-emulation/open-vm-tools: [VMWARE]

    • from 12.3.0 to 12.3.0-r1
    • synced with Gentoo, dropping all the OEM modifications
    • all the modifications are planned to be upstreamed to Gentoo
    • enabled vmhgfs-fuse
    • enabled installation of udev rules
    • enabled vgauth
    • enabled pam
    • added a user patch to tell the configure script to use kernel version from sys-kernel/coreos-kernel
    • containerinfo is still disabled, will work on enabling it later

--

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

This will replace files in coreos-base/oem-vmware package.
It's from Gentoo commit ecc674a080e039b5db316f4f8258315c1936801a.
None of these modifications are actually specific to Flatcar. This is
something we will want to upstream to Gentoo.
Ignition files are not necessary any more. Grub config file and
oem-releas file are now provided by the coreos-base/oem-common-files
package.

We install drop-in files for systemd units instead of providing our
own copies. This is where we set up PrivateTmp option and create
symlinks for /etc.

There's also manglefs.sh script, that will be executed by the
build_sysext utility. It drops unnecessary stuff like translations,
debugging symbols and development files.
This list will be used by bootengine to clean up old installation of
VMware OEM software before installing a sysext.
It's from Gentoo commit 7d00351296070d4b6cea6913fab62b96819abddb.
It's from Gentoo commit ba10b3c5f0eec6233e4dfbfa65db40253e7fdd7d.
It's from Gentoo commit 86f1cf927f6a27a19482e1eb25430e47d5f58ff7.
@krnowak krnowak marked this pull request as ready for review September 20, 2023 08:11
@krnowak krnowak requested review from a team and pothos September 20, 2023 08:11
@krnowak
Copy link
Member Author

krnowak commented Sep 20, 2023

CI passed.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

@pothos
Copy link
Member

pothos commented Sep 20, 2023

Thanks, it looks good and I will try to test by booting and looking around if that wasn't done yet.
We should test the migration as well by updating from an old instance twice and check that all is ok (sudo ./flatcar-update -E flatcar_test_update-oem-vmware.gz -P flatcar_test_update.gz -V 1.2.3 -D -A).
Done; all looks good!

Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants