overlay coreos-base/update_engine: fix build issues with gcc 13 #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
had a problem deploying
to
development
GitHub Actions
Error
Starting from gcc 13, it is required to explicitly include cstdint, as other standard library header files will not include other headers that were being used internally by the library. So update_engine also has to explicitly include cstdint to avoid build errors. Pulls in flatcar/update_engine#27
dongsupark
force-pushed
the
dongsu/update-engine-gcc-13
branch
from
9514b0b
to
15fea68
Compare
dongsupark
had a problem deploying
to
development
GitHub Actions
Failure
|
SDK and packages of CI passed. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6355798667 |
krnowak
approved these changes
Sep 29, 2023
|
I'll merge it to give today's nightly a chance to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from gcc 13, it is required to explicitly include cstdint, as other standard library header files will not include other headers that were being used internally by the library. So update_engine also has to explicitly include cstdint to avoid build errors.
Pulls in flatcar/update_engine#27.
Testing done
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1087/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.