build_packages: fix systemd cyclic deps resolver #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes "curl" from the USE flags to be removed to build systemd in the cyclic deps resolver step of build_packages. Excluding curl from systemd's USE flags leads to build breakage: 09:06:25 !!! The ebuild selected to satisfy "sys-apps/systemd" for /build/amd64-usr/ has unmet requirements. 09:06:25 - sys-apps/systemd-252.11-r1::coreos USE="audit dns-over-tls elfutils gcrypt gnuefi http idn importd iptables kmod lz4 lzma openssl pam pcre policykit resolvconf seccomp selinux (sysv-utils) (vanilla) zstd -acl -apparmor -cgroup-hybrid -cryptsetup -curl -fido2 -gnutls -homed -pkcs11 -pwquality -qrcode (-split-usr) -test -tpm -xkb" 09:06:25 09:06:25 The following REQUIRED_USE flag constraints are unsatisfied: 09:06:25 importd? ( curl ) 09:06:25 09:06:25 The above constraints are a subset of the following complete expression: 09:06:25 dns-over-tls? ( any-of ( gnutls openssl ) ) homed? ( cryptsetup pam openssl ) importd? ( curl lzma any-of ( gcrypt openssl ) ) pwquality? ( homed ) Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
krnowak
reviewed
Oct 19, 2023
| @@ -276,7 +276,7 @@ if [[ "${FLAGS_usepkgonly}" -eq "${FLAGS_FALSE}" ]]; then | |||
| break_dep_loop sys-apps/util-linux udev,systemd,cryptsetup \ | |||
| sys-fs/cryptsetup udev \ | |||
| sys-fs/lvm2 udev,systemd \ | |||
| sys-apps/systemd cryptsetup,curl \ | |||
| sys-apps/systemd cryptsetup \ | |||
There was a problem hiding this comment.
Instead of dropping curl, please add importd. That something I did in the build tag, but forgot to put it into the PR branch (6e20bf3)
There was a problem hiding this comment.
As discussed on Matrix, there's no difference in overall packages built...
krnowak
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes "curl" from the USE flags to be removed to build systemd in the cyclic deps resolver step of build_packages. Excluding curl from systemd's USE flags leads to build breakage: