T lo/build dev packages #1491
Merged
T lo/build dev packages #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started a Jenkins build: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3111/cldsv/ |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/7252203328 |
This change introduces build_dev_binpkgs, a script to build binary packages for all dependencies of the devcontainer. This works around an issue with build_packages, which doesn't - leading to build issues with the devcontainer later on. This particularly happens for more complex builds with the devcontainer. Additionally, a call to build_dev_binpkgs has been added to the package publishing step in ci-automation before binary packages are published. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This change adds a command line option to build_packages to stop execution of the script after breaking circular dependencies (i.e. before board packages are built). Helpful for debugging package build issues. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
force-pushed
the
t-lo/build-dev-packages
branch
from
29aea36
to
f68167d
Compare
|
Restarted the Jenkins CI after fixing an unbound variable issue: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3126/cldsv/ |
|
All tests are green on Jenkins CI, and updated packages now include libtool once again: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3126/cldsv/ |
pothos
reviewed
Dec 18, 2023
pothos
approved these changes
Dec 18, 2023
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
This was referenced Dec 18, 2023
|
Merged and cherry-picked for flatcar-3815. 3033, 3510, 3602 and 3760 required backports so these are dealt with in separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
build_dev_binpkgs, a script to build binary packages for all dependencies of the devcontainer. This works around an issue withbuild_packages, which doesn't - leading to build issues with the devcontainer later on. This particularly happens for more complex builds with the devcontainer.Additionally, a call to
build_dev_binpkgshas been added to the package publishing step in ci-automation before binary packages are published.Lastly, this change adds a command line option to
build_packagesto stop execution of the script after breaking circular dependencies (i.e. before board packages are built). This option was very helpful while working onbuild_dev_binpkgsand is likely to be similarly useful for other package build related development.Fixes flatcar/Flatcar#1292.
How to use
Testing done
Successfully built devcontainer packages for amd64 and arm64.
Backporting and cherry-picking
Should be backported / cherry-picked to all maintenance branches: flatcar-3033, flatcar-3510, flatcar-3602, flatcar-3760, flatcar-3815.