-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-emulation/amazon-ssm-agent: use upstream makefile #1572
Conversation
04df673
to
3ec03eb
Compare
...ird_party/coreos-overlay/app-emulation/amazon-ssm-agent/amazon-ssm-agent-3.2.985.0-r3.ebuild
Outdated
Show resolved
Hide resolved
# this is replication of commands from the vendor makefile | ||
# but without network activity during build phase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for the duplication was the network access, is this not the case anymore or if it is the case, are we fine with network access? We could also patch the Makefile instead of duplicating the commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been able to locally emerge without any issues - I think this is some legacy from an old setup (where vendor was not provided for example?)
By maintaining our own build logic, we missed the fact that the agent was now split in two parts: * amazon-ssm-agent in `./core` * ssm-agent-worker in `./agent` With the runtimeconfig passed from the `core` to the `agent`. We were currently shipping `ssm-agent-worker` as the `amazon-ssm-agent` hence some errors we had. ``` amazon-ssm-agent[8929]: 2023-12-28 15:29:32 WARN [ssm-agent-worker] failed to read runtime config 'identity_config.json': open /var/lib/amazon/ssm/runtimeconfig/identity_config.json: no such file or directory ``` Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
d3c9609
to
631a11f
Compare
app-emulation/amazon-ssm-agent: use upstream makefile Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
app-emulation/amazon-ssm-agent: use upstream makefile Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
By maintaining our own build logic, we missed the fact that the agent was now split in two parts:
./core
./agent
With the runtimeconfig passed from the
core
to theagent
.We were currently shipping
ssm-agent-worker
as theamazon-ssm-agent
hence some errors we had.changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Locally tested but a last test with the image from the CI will be good.
Closes: flatcar/Flatcar#1307 aws/amazon-ssm-agent#554