Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker 24.0.9, runc 1.1.12, containerd 1.7.13 for beta #1628

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Feb 6, 2024

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@krnowak krnowak requested a review from a team February 6, 2024 08:37
@pothos
Copy link
Member

pothos commented Feb 6, 2024

Thanks!
(I realize that containerd is in the coreos-overlay because it uses a version that wasn't available at that time but in general it looks like we could move it back to portage-stable, or? - Not for the release branch but in main)

Copy link

github-actions bot commented Feb 6, 2024

@krnowak
Copy link
Member Author

krnowak commented Feb 6, 2024

Thanks! (I realize that containerd is in the coreos-overlay because it uses a version that wasn't available at that time but in general it looks like we could move it back to portage-stable, or? - Not for the release branch but in main)

Yeah, we could move it to portage-stable now. We could also drop app-containers/docker-proxy from portage-stable as it is not pulled in any more.

@krnowak
Copy link
Member Author

krnowak commented Feb 6, 2024

Any clue what the failure in extra-test.[first_dual].cl.update.oem is about? Same happened in #1629.

@pothos
Copy link
Member

pothos commented Feb 6, 2024

Looks unrelated because it downloads something from bincache instead of an artifact of this PR

 first_dual: ++ curl --head -o /dev/null -fsSL --retry-delay 1 --retry 60 --retry-connrefused --retry-max-time 60 --connect-timeout 20 https://bincache.flatcar-linux.net/images/amd64/3815.1.0/flatcar_test_update-oem-azure.gz

@pothos
Copy link
Member

pothos commented Feb 6, 2024

Looks unrelated because it downloads something from bincache instead of an artifact of this PR

 first_dual: ++ curl --head -o /dev/null -fsSL --retry-delay 1 --retry 60 --retry-connrefused --retry-max-time 60 --connect-timeout 20 https://bincache.flatcar-linux.net/images/amd64/3815.1.0/flatcar_test_update-oem-azure.gz

Maybe the .github/ workflows are out of sync with main.

@krnowak
Copy link
Member Author

krnowak commented Feb 6, 2024

Looks unrelated because it downloads something from bincache instead of an artifact of this PR

 first_dual: ++ curl --head -o /dev/null -fsSL --retry-delay 1 --retry 60 --retry-connrefused --retry-max-time 60 --connect-timeout 20 https://bincache.flatcar-linux.net/images/amd64/3815.1.0/flatcar_test_update-oem-azure.gz

Maybe the .github/ workflows are out of sync with main.

Alright, I'll ignore it for now.

Kicked off the CI again, because containerd insisted on pulling in the old version of runc. Same thing done for alpha and main.

@krnowak krnowak merged commit de1c6d6 into flatcar-3815 Feb 7, 2024
5 of 7 checks passed
@krnowak krnowak deleted the krnowak/docker-runc-beta branch February 7, 2024 17:18
@pothos
Copy link
Member

pothos commented Feb 7, 2024

Kicked off the CI again, because containerd insisted on pulling in the old version of runc. Same thing done for alpha and main.

For a more simple approach to problems like this I would always delete the old ebuilds to prevent them from being used accidentally.

@krnowak
Copy link
Member Author

krnowak commented Feb 7, 2024

Kicked off the CI again, because containerd insisted on pulling in the old version of runc. Same thing done for alpha and main.

For a more simple approach to problems like this I would always delete the old ebuilds to prevent them from being used accidentally.

That would fail the build, as containerd had a dependency on any revision of runc 1.1.9. Admittedly that would be more noticable than just looking at the image reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants