-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_to_vm: add support for hyperv_vhdx format #1791
Conversation
1f98104
to
7264cc9
Compare
Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/. I don't like that the images end up being called |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8564352706 |
It is the same naming convention for rackspace and cloudstack. Adding gen2 in the naming would be wrong, and only multiplexing the |
@jepio I tested the image on a gen 2 vm, and the image does not properly boot with the initrd stage error: |
Code is failing here: https://github.com/coreos/ignition/blob/v2.18.0/internal/providers/hyperv/kvp.go#L50. |
Okay, I think I know why, because we are not using the upstream initrd generation for ignition, https://github.com/coreos/ignition/blob/d304850c3d3696822bc05e0833ee4b27df9d7a38/dracut/30ignition/module-setup.sh. This PR requires a bootengine PR to add that module. |
1076fc9
to
5026f47
Compare
5026f47
to
90ff90e
Compare
Test results look good, bootengine PR was merged with commit id updated, changelog was added. |
Note that the VHDX image file after decompression has 1.1GB in file size. |
90ff90e
to
3e924bc
Compare
3e924bc
to
6211142
Compare
6211142
to
5261eb6
Compare
Bootengine commit was removed, as the flatcar/scripts main is already using the newest bootengine HEAD. |
Almost^^ I had to push a fix as it was the repo's HEAD. |
I ll have to rebase on f04ba66, thought the commit was already in at that moment. |
5261eb6
to
872ad17
Compare
A new build is running (.11) and should show up under https://bincache.flatcar-linux.net/images/amd64/9999.9.11+ader1990-hyperv-vhdx-support/ |
b101201
to
ad1f305
Compare
Add support for Gen 2 Hyper-V VMs. `./image_to_vm` tool has now a new supported format: `hyperv_vhdx`, that produces .vhdx dynamic disks. How to use: ```bash ./image_to_vm.sh --from ../build/images/amd64-usr/developer-latest/ --format hyperv_vhdx ``` See: flatcar/Flatcar#1009 Uses PR: flatcar/bootengine#92 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ad1f305
to
7d4917d
Compare
Add support for Gen 2 Hyper-V VMs.
See: flatcar/Flatcar#1009
./image_to_vm
tool has now a new supported format:hyperv_vhdx
, that produces .vhdx dynamic disks.How to use
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.