Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-cloudinit: fix Equinix Metal cloudinit #2222

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Aug 9, 2024

This has been raised on Slack:

Aug 08 19:03:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:03:33 Checking availability of "packet-metadata-service"
Aug 08 19:04:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:04:03 Checking availability of "packet-metadata-service"
Aug 08 19:04:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:04:33 Checking availability of "packet-metadata-service"
Aug 08 19:05:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:05:03 Checking availability of "packet-metadata-service"
Aug 08 19:05:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:05:33 Checking availability of "packet-metadata-service"
Aug 08 19:06:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:06:03 Checking availability of "packet-metadata-service"
Aug 08 19:06:09 shoot-79548-jlptk bash[1678]: 2024/08/08 19:06:09 No datasources available in time
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: oem-cloudinit.service: Main process exited, code=exited, status=1/FAILURE
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: oem-cloudinit.service: Failed with result 'exit-code'.
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: Failed to start oem-cloudinit.service - Run cloudinit.

The check for metadata endpoint availability (curl https://metadata.packet.net/) returns a 404 so it fails.


This PR is testing: flatcar/coreos-cloudinit#28 - once the PR merged, we can just update the commit revision and drop the user patch.

Once built, the image will be available at: https://bincache.flatcar-linux.net/images/amd64/9999.9.0+tormath1-cloudinit/flatcar_production_packet_image.bin.bz2 for testing.

Testing done

@RiRa12621
Copy link

AFAIK the only way to test a custom image in Equinix is to use a custom image with ipxe booting, but for that we'd require vmlinux and initrd in separate bits.

@tormath1
Copy link
Contributor Author

AFAIK the only way to test a custom image in Equinix is to use a custom image with ipxe booting, but for that we'd require vmlinux and initrd in separate bits.

@RiRa12621 These should be available here:

Copy link

github-actions bot commented Aug 16, 2024

@jepio jepio marked this pull request as ready for review August 19, 2024 09:33
@jepio jepio requested a review from a team August 19, 2024 09:34
@jepio
Copy link
Member

jepio commented Aug 19, 2024

@chewi
Copy link
Contributor

chewi commented Aug 19, 2024

This is failing, but I think that's because of flatcar/Flatcar#1514?

@jepio
Copy link
Member

jepio commented Aug 20, 2024

The github CI is failing on a test that shouldn't be running in the github CI (confused)
The EM CI is extremely unreliable, someone really needs to take a look.

This has been raised on Slack:
```
Aug 08 19:03:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:03:33 Checking availability of "packet-metadata-service"
Aug 08 19:04:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:04:03 Checking availability of "packet-metadata-service"
Aug 08 19:04:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:04:33 Checking availability of "packet-metadata-service"
Aug 08 19:05:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:05:03 Checking availability of "packet-metadata-service"
Aug 08 19:05:33 shoot-79548-jlptk bash[1678]: 2024/08/08 19:05:33 Checking availability of "packet-metadata-service"
Aug 08 19:06:03 shoot-79548-jlptk bash[1678]: 2024/08/08 19:06:03 Checking availability of "packet-metadata-service"
Aug 08 19:06:09 shoot-79548-jlptk bash[1678]: 2024/08/08 19:06:09 No datasources available in time
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: oem-cloudinit.service: Main process exited, code=exited, status=1/FAILURE
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: oem-cloudinit.service: Failed with result 'exit-code'.
Aug 08 19:06:09 shoot-79548-jlptk systemd[1]: Failed to start oem-cloudinit.service - Run cloudinit.
```

The check for metadata endpoint availability (`curl https://metadata.packet.net/`) returns a 404 so it fails.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@chewi
Copy link
Contributor

chewi commented Aug 20, 2024

The github CI is failing on a test that shouldn't be running in the github CI (confused) The EM CI is extremely unreliable, someone really needs to take a look.

Which test in particular?

@jepio
Copy link
Member

jepio commented Aug 20, 2024

I can't find the failing GHA run anymore, but it looked like [first_dual].cl.update.oem was failing because of not being able to fetch the oem sysext from bincache, which is checked as a precondition before adding the test case here:
https://github.com/flatcar/scripts/blob/main/ci-automation/vendor-testing/qemu_update.sh#L100-L108

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio
Copy link
Member

jepio commented Aug 21, 2024

Pushed a changelog entry, GHA had passed before, and the EM testing looks about as good as before this change.
Will cherry-pick to all channels.

@jepio jepio merged commit a7f3c4d into main Aug 21, 2024
1 check failed
jepio added a commit that referenced this pull request Aug 21, 2024
coreos-cloudinit: fix Equinix Metal cloudinit
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio added a commit that referenced this pull request Aug 21, 2024
coreos-cloudinit: fix Equinix Metal cloudinit
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio added a commit that referenced this pull request Aug 21, 2024
coreos-cloudinit: fix Equinix Metal cloudinit
@jepio jepio deleted the tormath1/cloudinit branch August 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants