Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-modules: Enable kernel-module for mpi3mr #2355

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sfudeus
Copy link
Contributor

@sfudeus sfudeus commented Oct 2, 2024

Enable kernel module mpi3mr for MPI3MR I/O & RAID controllers

This enables the kernel module mpi3mr, which is required e.g. on modern DELL hardware (PERC gen12, e.g. H965 raid controllers).
The driver is part of the linux kernel since 5.2 from 2019.

Fixes flatcar/Flatcar#1255

Testing done

Currently building and testing on affected Dell bare-metal servers.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@sfudeus
Copy link
Contributor Author

sfudeus commented Oct 2, 2024

The failed checks at least partially seem to complain about not finding my commitid, do the checks maybe not support forks? And in which test outputs would I find infos about size changes? Generate reports against last ... does not really contain relevant output AFAICS.

@jepio
Copy link
Member

jepio commented Oct 2, 2024

The failed checks are expected, don't worry bout them. There is an image-size-change report in the CI logs that someone will review and then this is good to go (we'll also want to add a short changelog so that its easy to spot which release has this change).

Copy link

github-actions bot commented Oct 2, 2024

@ader1990
Copy link
Contributor

ader1990 commented Oct 3, 2024

Hello @sfudeus, I will rerun the image build, as yesterday there was a rather big decrease in the initrd size because of another PR, and we neede a new build so that the comparison can be made correctly.

@ader1990
Copy link
Contributor

ader1990 commented Oct 3, 2024

Hello @sfudeus, I will rerun the image build, as yesterday there was a rather big decrease in the initrd size because of another PR, and we neede a new build so that the comparison can be made correctly.

The new results are available:

./boot/flatcar/vmlinuz-a by 114688 bytes (112 kbytes) from 57391608 bytes (56046 kbytes, 54 mbytes) to 57506296 bytes (56158 kbytes, 54 mbytes)

There is a 112 KB increase of the /boot partition because of the expected increase in vmlinuz-a.

@sfudeus
Copy link
Contributor Author

sfudeus commented Oct 4, 2024

./boot/flatcar/vmlinuz-a by 114688 bytes (112 kbytes) from 57391608 bytes (56046 kbytes, 54 mbytes) to 57506296 bytes (56158 kbytes, 54 mbytes)

There is a 112 KB increase of the /boot partition because of the expected increase in vmlinuz-a.

Thanks for looking into this and the data.
Sounds reasonable and acceptable, doesn't it?

How do we go from here, ideally even getting this then backported to the current stable line (3975) or at least beta (4054)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[RFE] Add MPI3MR kernel module
4 participants