-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go from 1.19.10 and 1.20.5 to 1.19.11 and 1.20.6 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flatcar-infra
temporarily deployed
to
development
July 17, 2023 07:26
— with
GitHub Actions
Inactive
flatcar-infra
temporarily deployed
to
development
July 17, 2023 07:39
— with
GitHub Actions
Inactive
200+ tests failed with the following messages:
Added |
Already known issue in the upstream docker community. |
dongsupark
force-pushed
the
go-1.19.11-and-1.20.6-main
branch
from
July 18, 2023 14:49
8aef9c8
to
bdf1d11
Compare
Finally CI passed. |
Reset to the state according to the state of Gentoo upstream, to commit 964117a, to create Flatcar patches on top of that.
Apply Flatcar patches, based on commit 9d6af12.
Docker client and daemon started to fail at sending or handling most local connections when being compiled with Go 1.19.11, which addresses CVE-2023-29406 by blocking invalid host headers of HTTP/1. As a workaround, Docker started to define a dummy host header, and to use it for local connections. Backport the fixes to Flatcar to fix the runtime failures. See also moby/moby#45935, moby/moby#45942.
Reset to the state according to the state of Gentoo upstream, to commit b93160f. to create Flatcar patches on top of that.
Apply Flatcar patches, based on commit 817ad4c.
…valid header To fix invalid header issue that started to happen when being built with Go 1.19.11+, it is necessary for the docker cli repo to vendor the new docker client part of github.com/docker/docker. Based on docker/cli@5d4e44df90bb.
dongsupark
force-pushed
the
go-1.19.11-and-1.20.6-main
branch
from
July 20, 2023 08:24
3e7390e
to
f36ae06
Compare
krnowak
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject says it all.
Fixes flatcar/Flatcar#1117
/update-sdk
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/941/cldsv/